Human-Readable URLs are Back

[Monk Ed]

...And you are all my guinea pigs.

Tell me if something breaks.

[Mr. Tines]

I hover over the "Human-Readable URLs are Back" at the top of the page and the link that shows is "http://forum.evageeks.org/viewtopic.php?f=1&t=17980". The post URLs you get from the links are properly semantic

[Monk Ed]

I don't know what that means.

If it means "The link in your URL bar depends on how you got to the page" then yeah, it differs, and it looks like I haven't covered every angle from which one can get to a particular post/topic.

[Mr. Tines]

The page mark-up contains this HTML for the topic title

Code: Select all

<h2 class="topic-title"><a href="./../../../viewtopic.php?f=1&amp;t=17980">Human-Readable URLs are Back</a></h2>

rather than

Code: Select all

<h2 class="topic-title"><a href="http://forum.evageeks.org/thread/17980/Human-Readable-URLs-are-Back/">Human-Readable URLs are Back</a></h2>

or its relative path equivalent.

By contrast, individual posts do have the semantic URLs

Code: Select all

<p class="author"><a href="./../../../post/820498/Human-Readable-URLs-are-Back/#p820498"><span class="imageset icon_post_target" title="Post">Post</span></a><span class="responsive-hide">by <strong><a href="./../../../memberlist.php?mode=viewprofile&amp;u=3527" style="color: #FF7F00;" class="username-coloured">Monk Ed</a></strong> » </span>Fri Dec 11, 2015 04:22 UTC </p>

[Monk Ed]

Yeah, that changes depending on how you get to the page. If you select the topic from the forum view, for example, it should show up as (...)/thread/(number)/(title)/etc.

[NemZ]

I think this broke the quote button.

Edit: or maybe you were doing something else and that made it stop working briefly. dunno.

[Monk Ed]

Edit: or maybe you were doing something else and that made it stop working briefly.

This one.

Sorry.

*cough cough*

So was that outage just now.

This isn't how it's like for all my other ironing out of kinks -- it's just that I can't test this code out on the test instance due to difficulties getting it to understand the rewritten URLs.

[Monk Ed]

...Okay, finally. The "last post" link on the forum view should have a human readable URL now.



I think I still need to implement having a human readable URL when you submit a post or edit. Any other holes I missed?

[Bagheera]

...And you are all my guinea pigs.

Tell me if something breaks.

Confirmed. Links appear to work in Ghosts. Thanks, Monk!

[Monk Ed]

That was actually a separate issue, oddly enough, and solved a completely different way (by inserting a new anchor into every post -- both #p and # links work now). Not that I would expect you to know that. I sure didn't!

[Mr. Tines]

Yeah, that changes depending on how you get to the page. If you select the topic from the forum view, for example, it should show up as (...)/thread/(number)/(title)/etc.

I navigated from

Code: Select all

http://forum.evageeks.org/index.php

which linked me to

Code: Select all

http://forum.evageeks.org/viewforum.php?f=1

which linked me to

Code: Select all

http://forum.evageeks.org/thread/17980/Human-Readable-URLs-are-Back/?f=1

and that page contains the mark-up

Code: Select all

<a href="./../../../viewtopic.php?f=1&amp;t=17980">Human-Readable URLs are Back</a>

[Bagheera]

That was actually a separate issue, oddly enough, and solved a completely different way (by inserting a new anchor into every post -- both #p and # links work now). Not that I would expect you to know that. I sure didn't!

Oh. Well, thanks for solving it anyway!

[Monk Ed]

Pagination links should canonize now. That means that when you click on a page, regardless of what the page button tells you the link is it should redirect to the correct one once you get there.

The page mark-up contains this HTML for the topic title

With redirects now active, clicking that link regardless of what it says should go to the correct semantic URL. But I assume it's bad practice to rely on a redirect like that?

[NemZ]

good news... haven't seen that error in a while.

bad news... new post links take me to the first post in the thread instead.

[Mr. Tines]

But I assume it's bad practice to rely on a redirect like that?

It's an extra hit on the server; and it's also a regression from where we were last month.

I notice it because I was used to, when an appropriate question arose, looking up list of threads by title in the summary pages that Ornette had added, which just had the thread number in their URL, clicking through to the front page, then copying the semantic link from the thread title under the banner.

[Monk Ed]

bad news... new post links take me to the first post in the thread instead.

How 'bout now?

It's an extra hit on the server; and it's also a regression from where we were last month.

I figured.

Yeah, gotta find out where in the code that URL is formed...

[NemZ]

latest post links on the index work. latest post links on the 'unread posts' page do not.

[Monk Ed]

I completely forgot about that page!

I fixed it the cheap way for now. Maybe that's the only way it needs to be fixed.

EDIT: The same problem with relative URLs that's been causing other issues also makes the pagination on the page when you go to an unread post act weird too. This rabbit hole of special cases seems to get deeper all the time. PHPBB 3.1 really doesn't like URL rewriting.

[Mr. Tines]

Follow the topic latest post link to

Code: Select all

http://forum.evageeks.org/post/820778/What-are-Arael-and-Leliel-respective-modes-of-attack/#820778

Click the "Board index" link at the bottom of that page, get

Code: Select all

No route found for "GET /post/index.php"

[Monk Ed]

Follow the topic latest post link to

Code: Select all

http://forum.evageeks.org/post/820778/What-are-Arael-and-Leliel-respective-modes-of-attack/#820778

Click the "Board index" link at the bottom of that page, get

Code: Select all

No route found for "GET /post/index.php"

Works fine for me. Or did I fix it in between without knowing it?